Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump actions/cache and actions/setup-node #339

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Sep 17, 2024

check list

  • Add test cases for the changes.
  • Passed the CI test.

Description

actions/cache@v1 will soon be deprecated. The PR bumps the version of a few actions. The PR also excludes the macOS + Node.js 14 matrix (As there is no Node.js 14 arm64 build).

Additional information

https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/

@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 98.54%. remained the same
when pulling d4a67a0 on SukkaW:update-github-actions
into ffc8743 on hexojs:master.

exclude:
# https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#excluding-matrix-configurations
- os: macos-latest
node-version: 14.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can try to drop node14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be another PR IMHO.

@SukkaW SukkaW merged commit e9b3f30 into hexojs:master Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants